ArC: detect incorrect usage of javax.inject.Singleton #37648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Dec 11, 2023
mkouba
commented
- jakarta.inject.Singleton should be used instead
gsmet
reviewed
Dec 11, 2023
| @@ -44,6 +44,7 @@ void detect(ArcConfig config, ApplicationIndexBuildItem applicationIndex, Custom | |||
| unsupported.add(new UnsupportedAnnotation("com.google.inject.Singleton", correctSingleton)); | |||
| unsupported.add(new UnsupportedAnnotation("jakarta.ejb.Singleton", correctSingleton)); | |||
| unsupported.add(new UnsupportedAnnotation("groovy.lang.Singleton", correctSingleton)); | |||
| unsupported.add(new UnsupportedAnnotation("javax.inject.Singleton", correctSingleton)); | |||
There was a problem hiding this comment.
Do we handle @ApplicationScoped and friends somewhere?
There was a problem hiding this comment.
Nope, but it's not very common that the javax.enterprise:cdi-api is on the classpath, unlike javax.inject...
manovotn
approved these changes
Dec 11, 2023
mkouba
commented
Dec 11, 2023
| import jakarta.enterprise.event.Observes; | ||
| import jakarta.inject.Singleton; |
There was a problem hiding this comment.
@cescoffier To be honest - I don't understand what is the MyObserver used for?
mkouba
added
the
triage/waiting-for-ci
manovotn
approved these changes
Dec 11, 2023
This comment has been minimized.
This comment has been minimized.
- jakarta.inject.Singleton should be used instead
gsmet
force-pushed
the
detect-javax-singleton
branch
from
e27689a to
d1b359d
Compare
|
Rebasing CI as the failures are not related. |
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.